Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

moving to enum.Enum #646

Closed
tarekziade opened this issue Feb 10, 2016 · 3 comments
Closed

moving to enum.Enum #646

tarekziade opened this issue Feb 10, 2016 · 3 comments

Comments

@tarekziade
Copy link
Contributor

We have an ad-hoc Enum class at https://github.com/mozilla-services/cliquet/blob/master/cliquet/utils.py#L152

it behaves very differently from Python 3.4 Enum - https://docs.python.org/3/library/enum.html and even makes our Project shadow the stdlib Enum in 3.4

I don't see any good reason to keep ours, as we can use "enum34" which backports enum in all Python version.

However, that's not a small change - so I'd like to ask here before doing it - in case I am missing a good reason to keep it

@tarekziade
Copy link
Contributor Author

see the async notif for how that change can look like #647

@Natim
Copy link
Contributor

Natim commented Feb 10, 2016

For a long time Enum wasn't standardised in Python. I am glad we can now use an official version.

That seems like a good idea to me.

@leplatrem leplatrem reopened this Feb 11, 2016
@leplatrem
Copy link
Contributor

Merged in #652

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants