Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

Get rid of custom Enum (fixes #645) #652

Merged
merged 2 commits into from
Feb 16, 2016
Merged

Conversation

leplatrem
Copy link
Contributor

Isolated commit about Enum from #647

@tarekziade r?

@leplatrem
Copy link
Contributor Author

The .value everywhere bother me a bit, but I think it's sane to use a standard enum.

@almet @Natim any strong thought against it before we merge?

@Natim
Copy link
Contributor

Natim commented Feb 16, 2016

The .value everywhere bother me a bit, but I think it's sane to use a standard enum.

Same feeling, same conclusions.

@almet
Copy link
Contributor

almet commented Feb 16, 2016

yeah, it seems we're all there :-) Merging.

almet added a commit that referenced this pull request Feb 16, 2016
@almet almet merged commit 6d993dd into master Feb 16, 2016
@almet almet deleted the 645-switch-to-standard-enum branch February 16, 2016 11:02
@almet almet removed the in progress label Feb 16, 2016
@leplatrem leplatrem modified the milestone: 3.0.0 Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants