Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Reduce cardinality of InvalidHost errors in sentry #322

Closed
data-sync-user opened this issue Nov 19, 2021 · 0 comments · Fixed by #327
Closed

Reduce cardinality of InvalidHost errors in sentry #322

data-sync-user opened this issue Nov 19, 2021 · 0 comments · Fixed by #327
Assignees
@pjenvey

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Nov 19, 2021 •
edited
Loading

InvalidHost errors strings include the full url of the invalid advertiser "host" (or path). Consider a path including a parameter with the current timestamp: Sentry will consider the errors

“InvalidHost: https://foo.com?ts=1637340000” as a separate event from

”InvalidHost: https://foo.com?ts=1637340001”

Potentially causing many redundant sentry events.

We should probably only include solely the host domain in the error string. The full url could be included as an "extra" instead.

┆Issue is synchronized with this Jira Task
pjenvey added a commit that referenced this issue Nov 25, 2021
@pjenvey
feat: only include hostname in InvalidHost's err message
c8092d4 
to reduce the sentry event cardinality from paths/their query parameters

also include the full audience key & adm_url as extras

Closes #322
Closes #323
pjenvey added a commit that referenced this issue Nov 25, 2021
@pjenvey
feat: only include hostname in InvalidHost's err message
7f955fb 
to reduce the sentry event cardinality from paths/their query parameters

also include the full audience key & adm_url as extras

Closes #322
Closes #323
@pjenvey pjenvey mentioned this issue Nov 25, 2021
Merged
pjenvey added a commit that referenced this issue Nov 25, 2021
@pjenvey
feat: only include hostname in InvalidHost's err message
dc9e905 
to reduce the sentry event cardinality from paths/their query parameters

also include the full audience key & adm_url as extras

Closes #322
Closes #323
pjenvey added a commit that referenced this issue Nov 29, 2021
@pjenvey
feat: only include hostname in InvalidHost's err message (#327)
7727827 
to reduce the sentry event cardinality from paths/their query parameters

also include the full audience key & adm_url as extras

Closes #322
Closes #323
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: only include hostname in InvalidHost's err message mozilla-services/contile
2 participants
@pjenvey @data-sync-user