This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
feat: add timeout for calls to ADM service #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses setting `adm_timeout`, and defaults to 5 seconds I suspect that we probably may have different timeouts for various partners. There is no timeout specified for a default reqwest builder. Closes #139
pjenvey
suggested changes
Jun 7, 2021
src/settings.rs
Outdated
| @@ -58,6 +58,8 @@ pub struct Settings { | |||
| pub adm_max_tiles: u8, | |||
| /// number of tiles to query from ADM (default: 10) | |||
| pub adm_query_tile_count: u8, | |||
| /// Timeout requests to the ADM server after this many seconds (default: 3) | |||
There was a problem hiding this comment.
Suggested change
| /// Timeout requests to the ADM server after this many seconds (default: 3) | |
| /// Timeout requests to the ADM server after this many seconds (default: 5) |
There was a problem hiding this comment.
heh, oh, you saw that too? 🤦🏻♂️
pjenvey
approved these changes
Jun 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adm_timeout, and defaults to 5 secondsI suspect that we probably may have different timeouts for various
partners. There is no timeout specified for a default reqwest builder.
Testing
requests to ADM should take no longer than 5 seconds in default setting
Issue(s)
Closes #139