This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
bug: make UA name an 'extra' value for Sentry errors. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove tag hand off for get_UA * reduce cardinality for AdmServerError in sentry
pjenvey
reviewed
Jun 11, 2021
| @@ -164,7 +164,9 @@ pub async fn get_tiles( | |||
| .await | |||
| .map_err(|e| { | |||
| // ADM servers are down, or improperly configured | |||
| HandlerErrorKind::AdmServerError(e.to_string()) | |||
| let mut err: HandlerError = HandlerErrorKind::AdmServerError().into(); | |||
There was a problem hiding this comment.
We might want to keep the string for now and instead break down the type of error (later). Most of what we're seeing so far is err.is_timeout(), so we'd probably start there -- but probably be handy to know if it's something else before we fully break it all down.
There was a problem hiding this comment.
Oh but the string's obviously sent as an extra (I'm not sure I noticed this before 🤷♂️ ), so we're not losing it, this works for me.
We could map specific e.g. err.is_timeout() errors to their own individual error if we wanted later.
pjenvey
approved these changes
Jun 16, 2021
Trinaa
pushed a commit
that referenced
this pull request
Jun 13, 2022
…lack-22.1.0 Bump black from 21.12b0 to 22.1.0 in /client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to reduce some of the cardinality we're seeing with some sentry errors, it may be a good idea to move some of the data as "tag" info. (e.g. for InvalidUA and ADM Server Errors, we could move the "unique" bits as extra tag info so that we get a better idea of how many events we're seeing without using regular expression tricks.
Testing
test included (for InvalidUA at least)
Issue(s)
Closes #147