This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
bug: fix YAML schema warning for CircleCI config #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
approved these changes
Nov 29, 2021
ashrivastava-qa
approved these changes
Nov 29, 2021
@hackebrot Yea, this login step was added to our CI jobs across the org to avoid being hit by dockerhub's rate limiting (see mozilla-services/Dockerflow#58). |
|
Copied to the skeleton: mozilla-services/skeleton#8 |
pjenvey
approved these changes
Nov 29, 2021
|
Awesome, thanks for the review team! 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the YAML schema warning for the CircleCI config.
It replaces
=with-and fixes the indentation for therunstep.@pjenvey, I believe this job was generated from the skeleton. Do we want to login to DockerHub as part of this job?
Testing
Verify that the
Login to Dockerhubstep runs for thebuildjob on CI.Issue(s)
Resolve #328