bug: report error from image library #349
Conversation
|
@jrconlin When encountering this kind of error, is it possible for Contile to bail out rather than return an error code in the response? Doing so at least allows us to return some good tiles instead of nothing? |
|
This is currently failing tests because of the test suite change for mobile endpoints. #346 |
| .map_err(|_| HandlerErrorKind::BadImage("Image unreadable"))?; | ||
| let img = reader.decode().map_err(|e| { | ||
| let mut tags = Tags::default(); | ||
| tags.add_extra("error", &e.to_string()); |
There was a problem hiding this comment.
I think both url and format are really worth adding as extras here too -- the easiest way to do that is to probably shuffle this method around a bit to have the same signature as validate.
There was a problem hiding this comment.
Sigh.
the change was included in the merge e767a61
src/adm/tiles.rs
Outdated
| @@ -212,6 +212,7 @@ pub async fn get_tiles( | |||
| // We still want to track this as a server error later. | |||
| // | |||
| // TODO: Remove this after the shared cache is implemented. | |||
| dbg!(&e); | |||
Closes: #348