This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
bug: add check for image_hosts #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Mar 24, 2022
src/adm/settings.rs
Outdated
| serialize_with = "serialize_hosts", | ||
| default | ||
| )] | ||
| pub(crate) img_hosts: Vec<Vec<String>>, |
There was a problem hiding this comment.
nit: not terribly important but might as well match the field name in the json's prefix
Suggested change
| pub(crate) img_hosts: Vec<Vec<String>>, | |
| pub(crate) image_hosts: Vec<Vec<String>>, |
pjenvey
suggested changes
Mar 28, 2022
src/adm/filter.rs
Outdated
|
|
||
| if let Err(e) = self.check_image_hosts(img_filter, &mut tile, tags) { | ||
| trace!("Rejecting tile: bad img"); | ||
| metrics.incr_with_tags("filter.adm.err.invalid_img_host", Some(tags)); |
There was a problem hiding this comment.
Sorry to be pedantic but one more here, especially because we already have a few metrics with the word "image" in it.
Suggested change
| metrics.incr_with_tags("filter.adm.err.invalid_img_host", Some(tags)); | |
| metrics.incr_with_tags("filter.adm.err.invalid_image_host", Some(tags)); |
There was a problem hiding this comment.
Nope, good catch! I had done variable refactors for the others and they missed this.
TODO: consider s/img/image/g?
pjenvey
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #377