This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
chore: prefer CIRCLE_SHA1 vs CIRCLE_TAG in circle's cache key #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per mozilla-services/Dockerflow#44 _TAG seems to only fix this issue on tagged builds, whereas _SHA1 should also solve it on dev builds lacking a tag and switch the currently unused sccache key to CIRCLE_JOB Closes #380
|
Also the same change over here mozilla-services/skeleton#9 |
jrconlin
approved these changes
Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per mozilla-services/Dockerflow#44
_TAG seems to only fix this issue on tagged builds, whereas _SHA1 should also
solve it on dev builds lacking a tag
and switch the currently unused sccache key to CIRCLE_JOB
Closes #380