This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
chore: don't unpin the rust version #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncloudioj
previously approved these changes
Sep 26, 2022
and improve the comment warning about this
pjenvey
force-pushed
the
chore/pin-rust
branch
from
f0bf642 to
7330b4c
Compare
pjenvey
commented
Oct 3, 2022
| @@ -498,7 +498,7 @@ scenarios: | |||
| - name: accept | |||
| value: '*/*' | |||
| - name: user-agent | |||
| value: 'contile/1.8.0' | |||
| value: 'contile/1.8.1' | |||
There was a problem hiding this comment.
Logged #462 in hopes we can improve on the need to bump these values
jrconlin
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix the contract-tests for the new 1.8.1 release (don't hardcode contile's user-agent)