This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
feat: Add an adm_mobile_max_tiles setting (DISCO-2306)
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linabutler
force-pushed
the
disco-2306-mobile-max-tiles
branch
3 times, most recently
from
8d987de to
0dfe919
Compare
ncloudioj
reviewed
Apr 6, 2023
| }, | ||
| { | ||
| "id": 907, | ||
| "name": "Lasagna Come Out Tomorrow", |
There was a problem hiding this comment.
Lol. HERE WE GO, the Pun Master strikes again!
There was a problem hiding this comment.
😹 Now we have The Office, Breaking Bad, and The Good Place in our fixtures!
ncloudioj
previously approved these changes
Apr 6, 2023
This commit adds an option to separately control the maximum number of tiles returned to Desktop and mobile clients. Desktop clients use the `adm_max_tiles` setting now, and mobile clients use `adm_mobile_max_tiles` (falling back to `adm_max_tiles`).
linabutler
force-pushed
the
disco-2306-mobile-max-tiles
branch
from
0dfe919 to
b8e71cd
Compare
ncloudioj
approved these changes
Apr 6, 2023
linabutler
commented
Apr 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an option to separately control the maximum number of tiles returned to Desktop and mobile clients.
Desktop clients use the
adm_max_tilessetting now, and mobile clients useadm_mobile_max_tiles(falling back toadm_max_tiles).