-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add a metric to measure the tile count of adm response #533
Conversation
We could either increment a counter such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncloudioj FYI the distribution type isn't supported by telegraf's default configuration, however it can parse them when both these are set: datadog_extensions = true
(which we already have) and datadog_distributions = true
(which we don't).
So this will require to SRE add that.
src/adm/tiles.rs
Outdated
@@ -245,6 +245,12 @@ pub async fn get_tiles( | |||
})? | |||
} | |||
}; | |||
metrics.distribution_with_tags( | |||
"tiles.adm.response.distribution", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care if 'distribution' is included in this name but maybe something more specific:
"tiles.adm.response.distribution", | |
"tiles.adm.response.tiles_count", |
Thanks, Phil! I will double check with SRE to see if those changes are viable. If not, will reformat this to other metric types. |
Per SRE, we're using a pretty old version of InfluxDB so its support of the distribution metric type is unclear. Also, this work is due on May 5th, so let's use a counter metric for this for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count obviously isn't ideal here obviously but I guess we can at least look at the breakdown of counts over small intervals tagged by e.g. geo country code.
This closes DISCO-2346.
r? @pjenvey for extra eyeballs since this is the first time to use a distribution metric in Contile.