This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
fix: quick fixes to support the new adM API #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- specify form-factor & os-family - fixup region-code & handling of GCP load balancer's "client_region_subdivision" format - hardcode placement to "newtab" Closes #77
jrconlin
suggested changes
May 11, 2021
ncloudioj
reviewed
May 11, 2021
ncloudioj
reviewed
May 12, 2021
| // client_region_subdivision: a "Unicode CLDR subdivision ID, | ||
| // such as USCA or CAON" | ||
| if subdivision.len() < 3 { | ||
| subdivision |
There was a problem hiding this comment.
I wonder if we'd ever hit this branch as according to the doc the first two letters should always be the ISO-3166-2 country code. Just be safe ;)
There was a problem hiding this comment.
mumble mumble never trust outside data to be consistent mumble mumble
jrconlin
approved these changes
May 12, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"client_region_subdivision" format
Testing
This is a quick fix -- to be tested on the dev env deployment
Issue(s)
Closes #77