This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
feat: Make "country" and "placement" optional args #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
approved these changes
May 19, 2021
|
Heh, yeah, that can happen later, for now, I'm guessing making them optional prevents weird bugs and possibly makes testing easier. |
Trinaa
pushed a commit
that referenced
this pull request
Jun 13, 2022
…lake8-4.0.1 Bump flake8 from 3.9.2 to 4.0.1 in /partner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #83
Description
Make the URI
countryandplacementparameters optionalTesting
If not specified. the country should default to the origin IP address (or US if no
REMOTE_ADDRheader is present) and placement should default toNoneIssue(s)
Closes #83.