bug-1811299: update eliot to python 3.10 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Dec 4, 2023
| "iscoroutinefunction": ANY, | ||
| "re": "<module 're' from '/usr/local/lib/python3.9/re.py'>", | ||
| "wraps": ANY, | ||
| }, |
There was a problem hiding this comment.
I'm not sure why updating Python caused this change and didn't look into it.
There was a problem hiding this comment.
I don't know how the sentry package extracts the local variables, but my guess is they copy f_locals from the frame object. That has always been one of the weirder corners of Python, or at least since local variables aren't dictionaries anymore, so since the 2.0 release? Updates to f_locals are not reflected in local variables, and updates to local variables are not always reflected in f_locals as well.
I'm not surprised that this kind of change can happen when upgrading Python, and I don't think we care.
willkg
force-pushed
the
bug-1811299-py310
branch
from
4cb8463 to
ff6fdd6
Compare
smarnach
approved these changes
Dec 5, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Eliot to Python 3.10.13-slim-bullseye. I wanted to update to Python 3.11, but Falcon doesn't support Python 3.11, yet. They will with Falcon 4.0.
We're using bullseye (Debian 11) because we're using that across all our services for now. At some point, we'll switch all our services to bookworm (Debian 12).