This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Merged
Conversation
Contributor
|
Not looked at this in detail, but you might want to update package.json to remove the old dependency. |
Contributor
Author
added 8 commits
February 23, 2016 13:37
Natim
force-pushed
the
1246728-domain-stats-endpoint
branch
from
286c98b to
157313d
Compare
| var addHawk = require("superagent-hawk"); | ||
| var supertest = addHawk(require("supertest")); | ||
| var sinon = require("sinon"); | ||
| var assert = sinon.assert; |
Contributor
There was a problem hiding this comment.
Not sure this is a good idea as this could be easily mistaken for nodejs assert module.
Contributor
|
The code looks okay to me, but one more time I don't have much context about our metrics infrastructure to ensure it matches it and properly serves the intended purpose. So r+ conditional to other reviews from people from metrics. |
Natim
added a commit
that referenced
this pull request
Feb 24, 2016
…dpoint Bug 1246728 — Domain stats endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #363 to be able to use tags with statsd.