This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Bug 1243393 — Add an event route #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
force-pushed
the
1243393-add-a-GA-route
branch
from
2246697 to
e2236ca
Compare
Natim
force-pushed
the
1243393-add-a-GA-route
branch
from
f47823b to
3210c25
Compare
leplatrem
changed the title
loop/config.js
Outdated
| }, | ||
| ga: { | ||
| activated: { | ||
| doc: "Defines if uncaught exceptions should dump snapshots", |
There was a problem hiding this comment.
I don't think this is the right doc? I think it should be like "If true then POST /events will send event information to Google Analytics"
test/functional_test.js
Outdated
| .end(function(err) { | ||
| if (err) throw err; | ||
| assert.calledWithExactly(sendAnalyticsStub, "fake-ga-id", userHmac, { | ||
| 'event': 'tab_shared', |
Contributor
There was a problem hiding this comment.
Nit: Object keys don't need to be quoted.
Contributor
|
LGTM, totally unsure about the bool formatting issue which may just be me missing context here. r+ if not an issue, nits up to you. |
Natim
added a commit
that referenced
this pull request
Feb 29, 2016
Bug 1243393 — Add an event route
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1243393