This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Refresh the sessionId if the apiKey changed in the config.#370
Merged
Conversation
Natim
force-pushed
the
tokbox_room_sessionID_rotation
branch
from
13cd7f0 to
5e0b049
Compare
Contributor
|
r+ |
Contributor
|
Shouldn't we also be storing the apiKey when we initially create the room? |
Contributor
Ah, we seem to be doing that already here: loop-server/loop/routes/rooms.js Line 208 in 34631f4 In which case, the changes look good. |
Contributor
Author
|
Thanks for your feedback and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1266087