Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated skip logic #163

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Remove duplicated skip logic #163

merged 2 commits into from
Aug 12, 2022

Conversation

say-yawn
Copy link
Contributor

About this PR

Removing duplicate code that skips if the email tracker versioned list does NOT exist which was already handled later in the code:

shavar/shavar/lists.py

Lines 86 to 97 in 1faa189

try:
list_._source.load()
except NoDataError:
err_msg = (
'Skipping {0} version support for {1} '
'since the file does not exist in S3'
)
logger.error(err_msg.format(ver, list_name))
original_source = settings['source'].replace(
versioned_path.format(branch_name), original_path)
settings['source'] = original_source
continue

@say-yawn say-yawn requested a review from smarnach August 12, 2022 16:01
@say-yawn say-yawn merged commit 4827333 into master Aug 12, 2022
@say-yawn say-yawn deleted the remove-duplicate-code branch August 12, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants