Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1911367: remove psutil dependency #6849

Merged
merged 1 commit into from
Jan 6, 2025
Merged

bug-1911367: remove psutil dependency #6849

merged 1 commit into from
Jan 6, 2025

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Dec 30, 2024

We removed the processor process metrics, so we don't need this dependency anymore.

@willkg willkg requested a review from a team as a code owner December 30, 2024 14:26
Copy link
Contributor

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I was trying to understand what the process metrics were, why they were added in the first place, and why they are no longer needed.

I clicked down into all the history of this, and I think I found my answers largely via this comment (and the ticket its part of, and the ticket it's blocked by). Very tricksy!

Also, I confirmed there's no other references to psutil in the codebase.

@willkg willkg added this pull request to the merge queue Jan 2, 2025
@willkg
Copy link
Contributor Author

willkg commented Jan 2, 2025

Thank you!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@willkg willkg added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@willkg willkg added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@willkg
Copy link
Contributor Author

willkg commented Jan 2, 2025

Oh, I think I see what's going on. It's not re-running the checks, so the "Merge when ready" relates to the original run from last year and doesn't reflect the failed runs from the merge queue attempts. I think this is a beginning-of-year issue with one of the tests that uses week number for the index. I remember fixing something like this a few years back.

I'll look into it and fix it in another PR.

@willkg
Copy link
Contributor Author

willkg commented Jan 2, 2025

PR #6853 fixes the test. Once that lands, I'll rebase this and it should be mergeable.

We removed the processor process metrics, so we don't need this
dependency anymore.
@willkg willkg added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit dce8da2 Jan 6, 2025
1 check passed
@willkg willkg deleted the remove-psutil branch January 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants