-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Rust 1.58 and switch to GCP Rust crate #1201
Conversation
oof. Looks like a minor |
Sigh, and looks like after a |
I suppose we'll need to rebuild the GCP Rust bindings then? |
Not necessarily, or at least, not a full rebuild should be required. There are steps in the vendored directory you can do. |
I'll give it a shot! |
src/db/mysql/models.rs
Outdated
#[allow(clippy::non_send_fields_in_send_ty)] | ||
unsafe impl Send for MysqlDb {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's kill this, the warning was reverted in 1.58.1
#[allow(clippy::non_send_fields_in_send_ty)] | |
unsafe impl Send for MysqlDb {} | |
unsafe impl Send for MysqlDb {} |
@@ -1,4 +1,4 @@ | |||
FROM rust:1.57-buster as builder | |||
FROM rust:1.58-buster as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well since this hasn't merged yet (and its docker is up now) :)
FROM rust:1.58-buster as builder | |
FROM rust:1.58.1-buster as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if you specify 1.58, it pulls in the latest version subversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a docker pull rust:1.58-buster
and an internal shell
rustup show
shows 1.58.1
Description
Update to Rust 1.58 and start using the google-cloud-rust-raw crate instead of vendoring the GCP code.
Testing
N/A
Issue(s)
N/A