feat: plugin and cleanup various trait methods into MysqlDb: #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbooth
reviewed
Oct 26, 2018
| Box::new(future::ok(results::$type::default())) | ||
| mock_db_method!($name, $type, results::$type); | ||
| }; | ||
| ($name:ident, $type:ident, $result:ty) => { |
There was a problem hiding this comment.
Ah, of course, thus disproving my comment yesterday about having to use *. I hadn't thought about multiple match arms, nice one.
|
we'll have to workaround rust 1.30.0's rustdoc issues for the time being rust-lang/rust#54524 |
|
Should we just disable the docs script in CI until it's fixed? |
- kills get_collection_id (only used within the db layer now) - simplify uid_data! (just alias HawkIdentifier) - phrasing Issue #65
bbangert
approved these changes
Oct 26, 2018
philbooth
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #65