Make ports exposed in docker compose configurable

[relud]

see also mozilla-services/eliot#113

per https://github.com/mozilla-services/tecken/pull/2857/files#r1430382049

 "shutdownAction": "none",

biancadanforth Dec 18, 2023:
This is what prevents the devcontainer from shutting down when we close out of VS Code IIUC.

with devcontainer and its docker-compose dependencies running even when vscode isn't open, ports conflict between tecken, eliot, and socorro, so this PR makes the exposed ports configurable via environment variables, which can be set in .env in each project to avoid overlap.

[willkg]

${EXPOSE_REVIEW_APPROVED}

[smarnach]

How do you want to set the environment variables? If you set them in .env, they will only be used by the Makefile, and not if VS Code brings the container up. If you set them in your .bashrc, then all the variable names should contain TECKEN, so they don't conflict with variable names for other services.

[relud]

docker compose automatically picks up variables from .env https://docs.docker.com/compose/environment-variables/set-environment-variables/#substitute-with-an-env-file

I made sure it works by exiting vscode, running docker compose -f docker-compose.yml -f .devcontainer/docker-compose.yml down, opening vscode, waiting for the devcontainer to finish starting, and finally checking the exposed ports via docker compose -f docker-compose.yml -f .devcontainer/docker-compose.yml ps. the overrides that i had set in .env were used.

[smarnach]

Oh, nice! I didn't know. We should make use of that for the build arguments. They are currently passed in explicitly from the Makefile, but we should add them to docker-compose.yml instead.