bug-1906139: systemtests download API improvements #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancadanforth
force-pushed
the
bug-1906139
branch
from
2679db3
to
6920628
Compare
biancadanforth
commented
Jul 25, 2024
Because: * We will rely on systemtests as a primary way to validate the Tecken GCP migration. * We were not testing HEAD requests or verifying response headers in the systemtests for the download API. This commit: * Tests the HTTP response for HEAD requests. * Checks response headers for both the Tecken redirect response and the storage backend response for all envs except local. * We don't check in local, because the emulators don't currently return the correct response headers, and for the Tecken redirect response headers, the headers being tested are CSP headers that are added by nginx which is not present in the local environment. * What headers to check for and their values is based largely on the specifications in the [Tecken GCP migration plan](https://docs.google.com/document/d/1tLoGhMJQrP1m6A5H3D5zElNbTHQ9_vzYbOE9QnrxLUc/edit?usp=sharing).
biancadanforth
force-pushed
the
bug-1906139
branch
from
6920628
to
7fad8a4
Compare
smarnach
approved these changes
Jul 26, 2024
…t-Security-Policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: