bug-1906113: upgrade markus to 5.0.0 #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses markus 5.0.0's new AnyTagValue and lets us assert things about tags ignoring values that change from test run to test run.
This documents all metrics in a format similar to how Glean defines metrics. This adds a filter when running tests that raises an error if a metric is emitted that's not documented. This adds a Sphinx extension that automatically documents all metrics defined in `tecken/tecken_metrics.yaml`.
relud
approved these changes
Aug 6, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade markus to 5.0.0.
Switch to markus 5.0.0's new AnyTagValue and lets us assert things about tags ignoring values that change from test run to test run.
Documents all metrics in a format similar to how Glean defines metrics. This adds a filter when running tests that raises an error if a metric is emitted that's not documented.
This adds a Sphinx extension that automatically documents all metrics defined in
tecken/tecken_metrics.yaml.To review:
make docs)