bug-1906113: remove eliot references #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
force-pushed
the
willkg-bug-1906113-markus-fixes
branch
3 times, most recently
from
ff1d911
to
9c29c64
Compare
This fixes a bunch of copy-paste errors and switches to statsd-centric language. This also removes LogAllMetricsKeys which we don't use.
willkg
force-pushed
the
willkg-bug-1906113-markus-fixes
branch
from
4c4ffae
to
3149d97
Compare
willkg
commented
Aug 19, 2024
| _IS_MARKUS_SETUP = True | ||
|
|
||
|
|
||
| class LogAllMetricsKeys(BackendBase): # pragma: no cover |
There was a problem hiding this comment.
We don't need this since we only allow documented metrics to be used via the RegisteredMetricsFilter.
relud
approved these changes
Aug 19, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of copy-paste errors and switches to statsd-centric language.