Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1909013: remove upload now view forms #2994

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Aug 15, 2024

This removes the forms from the Symbols Upload Now page. I kept the page because it contains a link to instructions on how to upload symbols using Python and curl. That seems helpful to keep.

This PR gets into a lot of react code I'm not wildly familiar with (and has no tests) so I might have missed some bits when cleaning up. However, only a handful of people in the world have the access on Mozilla Symbols to see this page, so this is pretty low risk even if we mess up.

@willkg
Copy link
Contributor Author

willkg commented Aug 15, 2024

I opened a new PR, but CircleCI keeps the same pipeline. I'll try pushing a new commit.

willkg added 2 commits August 19, 2024 12:08
This removes the forms from the Symbols Upload Now page. I kept the page
because it contains a link to instructions on how to upload symbols
using Python and curl. That seems helpful to keep.
@willkg willkg force-pushed the willkg-bug-1909013-upload-now branch from 44e215b to 037864f Compare August 19, 2024 16:09
@willkg willkg marked this pull request as ready for review August 19, 2024 16:13
@willkg willkg requested a review from a team as a code owner August 19, 2024 16:13
@willkg willkg requested a review from relud August 19, 2024 16:13
@willkg willkg merged commit 25dc578 into main Aug 19, 2024
2 checks passed
@willkg willkg deleted the willkg-bug-1909013-upload-now branch August 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants