bug-1909870: Make system test cases independent of each other. #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
approved these changes
Sep 11, 2024
smarnach
force-pushed
the
new-systemtests
branch
from
144b0ea
to
ba8b972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the system test cases independent of each other. I combined the basic upload and download tests into a single test case. All other tests that need an upload simply upload a small archive first.
This change leads to a higher number of uploads when the system tests run. Since we switched to connection limiting for our Tecken deployments, this no longer leads to any rate limiting on the server side. We also introduced a lifecycle rule for our GCS buckets that expires the uploaded files early.