Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(javascript): finishStreamWithMetadata binding violates strict mode #2979

Closed
mmccartn opened this issue May 5, 2020 · 1 comment
Closed

Comments

@mmccartn
Copy link

mmccartn commented May 5, 2020

Stream.finishStreamWithMetadata does not declare the result variable upon first assignment in a strict module

Error message:

(node:13440) UnhandledPromiseRejectionWarning: ReferenceError: result is not defined

Minimal code to reproduce:

new Model('path/to/model.pbmm').createStream().finishStreamWithMetadata()

To fix, declare the result object during 1st assignment:

let result = binding.FinishStreamWithMetadata(this._impl, aNumResults);
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant