Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set graph's random seed when training #1780

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Set graph's random seed when training #1780

merged 2 commits into from
Dec 12, 2018

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Dec 11, 2018

No description provided.

@reuben reuben requested a review from lissyx December 11, 2018 23:49
@lissyx
Copy link
Collaborator

lissyx commented Dec 12, 2018

@reuben Looks like something regressed into + '[' -z 'she had a due in greasy wash water year' -o -z 'she had out in greasy wash water all year' ']' (but not from this patch)

Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -111,7 +111,7 @@ def create_flags():

# Initialization

tf.app.flags.DEFINE_integer ('random_seed', 4567, 'default random seed that is used to initialize variables')
tf.app.flags.DEFINE_integer ('random_seed', 4568, 'default random seed that is used to initialize variables')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git commit says "75 epochs" but tc-train-tests.sh still uses 105 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably why it wasn't failing so often. 75 is from run-ldc93s1.sh

@reuben
Copy link
Contributor Author

reuben commented Dec 12, 2018

The prod test failures are most likely from #1744

@reuben reuben merged commit f0ba315 into master Dec 12, 2018
@reuben reuben deleted the set-random-seed branch December 12, 2018 12:04
@lock
Copy link

lock bot commented Jan 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants