Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optimizer for lm_alpha + lm_beta #2783

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Added optimizer for lm_alpha + lm_beta #2783

merged 2 commits into from
Mar 17, 2020

Conversation

kdavis-mozilla
Copy link
Contributor

No description provided.

@community-tc-integration
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

Copy link
Contributor

@rhamnett rhamnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for optimizer.py to run correctly

optimizer.py Outdated Show resolved Hide resolved
@rhamnett
Copy link
Contributor

Good work :)

@piraka9011
Copy link
Contributor

This is awesome, thanks! I was just going to go about implementing my own :)
I'd like to give this a shot on my own model. It doesn't look like I need to recompile DS for this, correct?

@kdavis-mozilla
Copy link
Contributor Author

Thanks, and you don't need to re-compile.

Copy link
Contributor

@reuben reuben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome \o/

Just one comment, maybe rename this file to something less generic?

@kdavis-mozilla
Copy link
Contributor Author

@reuben Do you have any ideas? Maybe lm_optimizer.py?

@reuben
Copy link
Contributor

reuben commented Mar 17, 2020

Yeah I like lm_optimizer.py.

@lock
Copy link

lock bot commented Apr 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants