-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing ErrorCode API in Tree bindings #2806
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
@kdavis-mozilla @reuben Am I doing the right way? |
For .NET in nativeimp.cs do i add this for DS_ErrorCodeToErrorMessage?
|
@imskr
then when you call DS_ErrorCodeToErrorMessage :
|
@lissyx Thanks I will make the changes. |
@imskr I'm not sure we should do that in this bug or file a followup to address, but once this is live, we might want to take the opportunity to update all docs references of "return zero on success non-zero on failure" to refer to error code structure. |
Yes. I think we can make the necessary changes and for docs make another PR maybe. |
@lissyx Where should I make changes for the doc? And should I open new PR for the doc? |
Which doc changes ? Those ?:
|
Yes |
@carlfm01 Is it good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@lissyx Doc updation? |
Sorry but I still dont know what you are referring to. Please be precise, there are many context-dependant discussions around doc her. |
@lissyx sorry for the confusion. You mentioned earlier to update all docs references of "return zero on success non-zero on failure" to refer to error code structure. So this PR is good according to the issue. I was asking should I create new PR for docs reference? |
Yes, please. |
@lissyx docs where I will make changes are in doc directory right? |
Yeah, but you might want to verify everywhere, just in case. |
@imskr Please have a look at the |
|
There's also a warning:
|
@lissyx Should I delete line causing warning I think we can ignore this warning |
That'd be my guess, but @carlfm01 is the real source of truth here. |
@lissyx For warning I think we are converting it to |
@carlfm01 How should I get rid of that error? |
Yes, this is no longer required. And to convert Enums into ints please use Please debug and make sure that the parsed errorCode is still the desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Exposing our
DS_ErrorCodeToErrorMessage
API to our tree bindingsCloses #2773