-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically install ds_ctcdecoder in setup.py #2871
Conversation
@@ -122,25 +122,3 @@ verify_bazel_rebuild() | |||
exit 1 | |||
fi; | |||
} | |||
|
|||
# Should be called from context where Python virtualenv is set | |||
verify_ctcdecoder_url() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth adding unit test coverage of the similar feature we have in setup.py
? Your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to test setup.py
. I guess installing the package and then trying to import the decoder dependency to see if it works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not going to test the entire URL computation part that users will use, though.
doc/TRAINING.rst
Outdated
@@ -46,22 +46,15 @@ Install the required dependencies using ``pip3``\ : | |||
.. code-block:: bash | |||
|
|||
cd DeepSpeech | |||
pip3 install -e . | |||
pip3 install --upgrade pip wheel setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need latest version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, but depending on the OS/distro/Python version fresh virtualenvs come with older versions so for users of the training code I added this instruction to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example some versions are incompatible with TF 1.15 wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but forcing always latest version can bring its own issues. I'd feel better if we could stick to well known versions, like we do at several other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green tests :)
X-DeepSpeech: NOBUILD
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.