Automatically install ds_ctcdecoder in setup.py #2871
Conversation
| @@ -122,25 +122,3 @@ verify_bazel_rebuild() | |||
| exit 1 | |||
| fi; | |||
| } | |||
|
|
|||
| # Should be called from context where Python virtualenv is set | |||
| verify_ctcdecoder_url() | |||
There was a problem hiding this comment.
Maybe worth adding unit test coverage of the similar feature we have in setup.py ? Your call.
There was a problem hiding this comment.
I'm not sure how to test setup.py. I guess installing the package and then trying to import the decoder dependency to see if it works?
There was a problem hiding this comment.
It's still not going to test the entire URL computation part that users will use, though.
doc/TRAINING.rst
Outdated
| @@ -46,22 +46,15 @@ Install the required dependencies using ``pip3``\ : | |||
| .. code-block:: bash | |||
|
|
|||
| cd DeepSpeech | |||
| pip3 install -e . | |||
| pip3 install --upgrade pip wheel setuptools | |||
There was a problem hiding this comment.
Do we need latest version ?
There was a problem hiding this comment.
I don't think so, but depending on the OS/distro/Python version fresh virtualenvs come with older versions so for users of the training code I added this instruction to be safe.
There was a problem hiding this comment.
For example some versions are incompatible with TF 1.15 wheels.
There was a problem hiding this comment.
Sure, but forcing always latest version can bring its own issues. I'd feel better if we could stick to well known versions, like we do at several other places.
X-DeepSpeech: NOBUILD
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.