Return Stream wrapper in JS Model.createStream, add test coverage (Fixes #2956) #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben
changed the title
lissyx
reviewed
Apr 29, 2020
| @@ -511,3 +511,22 @@ run_cpp_only_inference_tests() | |||
| set -e | |||
| assert_correct_ldc93s1_lm "${phrase_pbmodel_withlm_intermediate_decode}" "$status" | |||
| } | |||
|
|
|||
| run_js_streaming_inference_tests() | |||
There was a problem hiding this comment.
I suspect we will need that for more than JS, maybe there is no need to name it like that? Even if we add testing later
There was a problem hiding this comment.
As long as we keep it consistently as a "--stream" parameter it should be fine. I'll leave the renaming for whenever we add another binding. Python already has streaming API coverage through the concurrent streams test.
reuben
force-pushed
the
nodejs-stream-wrapper
branch
from
05c1b0e
to
6f83e05
Compare
lissyx
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.