Fixes #233, removed built-in extensions

[Metropass]

Removed from configure_firefox.py:
ghostery
uBlock Origin
https-everywhere

I also removed the whitespace to save a few bytes. I checked deploy_browser.py, deploy_firefox.py, and selenium_firefox.py just to make sure the removed extensions aren't referenced, but I found nothing.

I deleted the references within default_browser_params.json

[vringar]

Could you please also delete this entire folder https://github.com/mozilla/OpenWPM/tree/master/automation/DeployBrowsers/firefox_extensions

[vringar]

Also I'm disabling the localstack tests for now, as I can't find a fix. This means you'll have to merge the master branch into your branch once #756 gets merged.

[Metropass]

Also I'm disabling the localstack tests for now, as I can't find a fix. This means you'll have to merge the master branch into your branch once #756 gets merged.

Noted, will do!

[codecov]

Codecov Report

Merging #754 into master will decrease coverage by 0.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   40.81%   40.10%   -0.71%     
==========================================
  Files          29       29              
  Lines        3183     3159      -24     
==========================================
- Hits         1299     1267      -32     
- Misses       1884     1892       +8     

Impacted Files	Coverage Δ
automation/DeployBrowsers/configure_firefox.py	2.19% <ø> (-2.16%)	⬇️
automation/DataAggregator/S3Aggregator.py	20.33% <0.00%> (-9.75%)	⬇️
automation/DataAggregator/BaseAggregator.py	62.22% <0.00%> (-1.49%)	⬇️
automation/MPLogger.py	65.24% <0.00%> (-1.22%)	⬇️
automation/TaskManager.py	77.74% <0.00%> (-0.63%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee163a...efe2e52. Read the comment docs.

[vringar]

LGTM. Do you have anything you still want to do?

[Metropass]

LGTM. Do you have anything you still want to do?

In terms of this PR, I think we got everything, but I was wondering if I can assist in issue #743 ? @vringar

[vringar]

I just realize we also don't need
https://github.com/mozilla/OpenWPM/blob/2b1a54eff38feebb737abf402382156e7b2a7438/automation/DeployBrowsers/configure_firefox.py#L19-L22
any more. Which means we should also remove
https://github.com/mozilla/OpenWPM/blob/2b1a54eff38feebb737abf402382156e7b2a7438/automation/DeployBrowsers/configure_firefox.py#L4-L7

[vringar]

Regarding #743 I'd wait a bit to see if the person currently assigned on it responds, but feel free to have a look at it.
If you want to spend more time on OpenWPM in general, I can also go through the issues and ping you on stuff that's interesting.

[Metropass]

Regarding #743 I'd wait a bit to see if the person currently assigned on it responds, but feel free to have a look at it.
If you want to spend more time on OpenWPM in general, I can also go through the issues and ping you on stuff that's interesting.

Yeah that'll be great, thank you so much! 😄

[Metropass]

I just realize we also don't need

https://github.com/mozilla/OpenWPM/blob/2b1a54eff38feebb737abf402382156e7b2a7438/automation/DeployBrowsers/configure_firefox.py#L19-L22

any more. Which means we should also remove

https://github.com/mozilla/OpenWPM/blob/2b1a54eff38feebb737abf402382156e7b2a7438/automation/DeployBrowsers/configure_firefox.py#L4-L7

Noted, I'll take care of that.