Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled s3 tests #756

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Disabled s3 tests #756

merged 1 commit into from
Sep 30, 2020

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Sep 30, 2020

This way we can get CI passing again.
Closes #755

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #756 into master will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   40.81%   39.89%   -0.92%     
==========================================
  Files          29       29              
  Lines        3183     3183              
==========================================
- Hits         1299     1270      -29     
- Misses       1884     1913      +29     
Impacted Files Coverage Δ
automation/DataAggregator/S3Aggregator.py 20.33% <0.00%> (-9.75%) ⬇️
automation/DataAggregator/BaseAggregator.py 62.22% <0.00%> (-1.49%) ⬇️
automation/MPLogger.py 65.24% <0.00%> (-1.22%) ⬇️
automation/TaskManager.py 77.74% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee163a...3a2349c. Read the comment docs.

@vringar vringar merged commit c2a7004 into master Sep 30, 2020
@vringar vringar deleted the disable_localstack_tests branch September 30, 2020 11:13
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this pull request Aug 10, 2021
This way we can get CI passing again.
Closes openwpm#755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localstack is once again broken
1 participant