Skip to content

Commit

Permalink
Disabling s3 tests (openwpm#756)
Browse files Browse the repository at this point in the history
This way we can get CI passing again.
Closes openwpm#755
  • Loading branch information
Stefan Zabka authored Sep 30, 2020
1 parent 5c7a60c commit b88b9ec
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions test/test_s3_aggregator.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
import os
import time
from collections import defaultdict

Expand Down Expand Up @@ -43,6 +44,10 @@ def get_config(self, num_browsers=1, data_dir=""):
browser_params[i]["dns_instrument"] = True
return manager_params, browser_params

@pytest.mark.skipif(
"TRAVIS" in os.environ and os.environ["TRAVIS"] == "true",
reason="Localstack fails to start on Travis",
)
def test_basic_properties(self):
TEST_SITE = "%s/s3_aggregator.html" % BASE_TEST_URL
NUM_VISITS = 2
Expand Down Expand Up @@ -86,6 +91,10 @@ def test_basic_properties(self):
config = json.loads(str(dataset.get_file(config_file[0]), "utf-8"))
assert len(config["browser_params"]) == NUM_BROWSERS

@pytest.mark.skipif(
"TRAVIS" in os.environ and os.environ["TRAVIS"] == "true",
reason="Localstack fails to start on Travis",
)
def test_commit_on_timeout(self):
TEST_SITE = "%s/s3_aggregator.html" % BASE_TEST_URL
manager_params, browser_params = self.get_config(num_browsers=1)
Expand All @@ -105,6 +114,10 @@ def test_commit_on_timeout(self):
assert TEST_SITE in requests.top_level_url.unique()
manager.close()

@pytest.mark.skipif(
"TRAVIS" in os.environ and os.environ["TRAVIS"] == "true",
reason="Localstack fails to start on Travis",
)
def test_s3_callbacks(self):
TEST_SITE = BASE_TEST_URL + "/test_pages/simple_a.html"
manager_params, browser_params = self.get_config()
Expand Down

0 comments on commit b88b9ec

Please sign in to comment.