Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Mozilla Central about:home search is autofocused #2007

Closed
sarracini opened this issue Jan 18, 2017 · 7 comments
Closed

Mozilla Central about:home search is autofocused #2007

sarracini opened this issue Jan 18, 2017 · 7 comments

Comments

@sarracini
Copy link
Contributor

sarracini commented Jan 18, 2017

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1382891
Split from #1974. When opening about:home it auto focuses to the search bar

@Mardak
Copy link
Member

Mardak commented Aug 23, 2017

So we will be doing this to avoid impacting any existing search metrics.

@Mardak
Copy link
Member

Mardak commented Aug 31, 2017

Looks like we can't use autofocus facebook/react#3066

So we'll want to detect visibility to focus but only the first visibility after the latest mount to avoid stealing focus. There's existing lib and components that individually check visibility, so potentially that can be shared and exported from https://github.com/mozilla/activity-stream/blob/master/system-addon/content-src/lib/detect-user-session-start.js

@Mardak
Copy link
Member

Mardak commented Sep 11, 2017

We will be conservative and keep the existing focus-search-in-content behavior. But we will put this behind a pref so that we can experiment via Shield study during Beta 57 to keep focus in location bar.

The experiment will want to measure total search volume (from location bar, content, etc.) and probably go with the one that has most search. There may be per-region considerations to consider. Product to figure out details.

@Mardak
Copy link
Member

Mardak commented Sep 12, 2017

I suppose we can use this pref name: browser.newtabpage.activity-stream.aboutHome.autoFocus

@Mardak Mardak assigned rlr and unassigned Mardak Sep 12, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 13, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 13, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 13, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 13, 2017
rlr added a commit that referenced this issue Sep 13, 2017
fix (systemaddon): #2007 autofocus search box for about:home
@rlr
Copy link
Contributor

rlr commented Sep 13, 2017

0c188ea

@rlr rlr closed this as completed Sep 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants