Address review comments

mozilla · May 3, 2018 · 8b0d81c · 8b0d81c
1 parent 05526b2
commit 8b0d81c
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 18 deletions.
diff --git a/src/amo/reducers/recommendations.js b/src/amo/reducers/recommendations.js
@@ -12,17 +12,17 @@ export const LOAD_RECOMMENDATIONS: 'LOAD_RECOMMENDATIONS'
   = 'LOAD_RECOMMENDATIONS';
 
 export type Recommendations = {|
-  addons: Array<ExternalAddonType>,
-  fallbackReason: string,
+  addons: Array<ExternalAddonType> | null,
+  fallbackReason: string | null,
   loading: boolean,
-  outcome: string,
+  outcome: string | null,
 |};
 
-export type RecommendationsState = {
+export type RecommendationsState = {|
   byGuid: {
     [guid: string]: Recommendations,
   },
-};
+|};
 
 export const initialState: RecommendationsState = {
   byGuid: {},
@@ -40,6 +40,7 @@ type AbortFetchRecommendationsAction = {|
 export const abortFetchRecommendations = ({
   guid,
 }: AbortFetchRecommendationsParams = {}): AbortFetchRecommendationsAction => {
+  invariant(guid, 'guid is required');
   return {
     type: ABORT_FETCH_RECOMMENDATIONS,
     payload: { guid },
@@ -110,15 +111,15 @@ export const getRecommendationsByGuid = (
   { guid, state }: GetRecommendationsByGuidParams
 ): Recommendations | null => {
   invariant(guid, 'guid is required');
+  invariant(state, 'state is required');
 
   return state.byGuid[guid] || null;
 };
 
 type Action =
   | AbortFetchRecommendationsAction
   | FetchRecommendationsAction
-  | LoadRecommendationsAction
-  ;
+  | LoadRecommendationsAction;
 
 const reducer = (
   state: RecommendationsState = initialState,
@@ -131,7 +132,10 @@ const reducer = (
         byGuid: {
           ...state.byGuid,
           [action.payload.guid]: {
+            addons: null,
+            fallbackReason: null,
             loading: false,
+            outcome: null,
           },
         },
       };
@@ -142,7 +146,10 @@ const reducer = (
         byGuid: {
           ...state.byGuid,
           [action.payload.guid]: {
+            addons: null,
+            fallbackReason: null,
             loading: true,
+            outcome: null,
           },
         },
       };

diff --git a/src/amo/sagas/recommendations.js b/src/amo/sagas/recommendations.js
@@ -27,11 +27,12 @@ export function* fetchRecommendations({
       api: state.api, guid, recommended,
     };
     const recommendations = yield call(api.getRecommendations, params);
-    const { outcome } = recommendations;
+    const { fallback_reason: fallbackReason, outcome, results: addons }
+      = recommendations;
 
     yield put(loadRecommendations({
-      addons: recommendations.results,
-      fallbackReason: recommendations.fallback_reason,
+      addons,
+      fallbackReason,
       guid,
       outcome,
     }));

diff --git a/tests/unit/amo/api/test_recommendations.js b/tests/unit/amo/api/test_recommendations.js
@@ -1,9 +1,7 @@
 import * as api from 'core/api';
 import { getRecommendations } from 'amo/api/recommendations';
 import { createApiResponse } from 'tests/unit/helpers';
-import {
-  dispatchClientMetadata,
-} from 'tests/unit/amo/helpers';
+import { dispatchClientMetadata } from 'tests/unit/amo/helpers';
 
 
 describe(__filename, () => {

diff --git a/tests/unit/amo/reducers/test_recommendations.js b/tests/unit/amo/reducers/test_recommendations.js
@@ -30,10 +30,9 @@ describe(__filename, () => {
     }));
 
     expect(state.byGuid[guid].loading).toEqual(true);
-    expect(state.byGuid[guid].addons).toEqual(undefined);
+    expect(state.byGuid[guid].addons).toEqual(null);
   });
 
-
   it('loads recommendations', () => {
     const addons = [fakeAddon, fakeAddon];
     const fallbackReason = 'timeout';
@@ -50,7 +49,6 @@ describe(__filename, () => {
 
     const loadedRecommendations = getRecommendationsByGuid({ guid, state });
 
-    expect(loadedRecommendations).not.toEqual(null);
     expect(loadedRecommendations).toEqual({
       addons: expectedAddons,
       fallbackReason,

diff --git a/tests/unit/amo/sagas/test_recommendations.js b/tests/unit/amo/sagas/test_recommendations.js
@@ -16,15 +16,14 @@ import {
 
 
 describe(__filename, () => {
-  let clientData;
   let errorHandler;
   let mockApi;
   let sagaTester;
 
   beforeEach(() => {
+    const clientData = dispatchClientMetadata();
     errorHandler = createStubErrorHandler();
     mockApi = sinon.mock(recommendationsApi);
-    clientData = dispatchClientMetadata();
     sagaTester = new SagaTester({
       initialState: clientData.state,
       reducers: {