Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start value has mixed support, consider using flex-start instead #3110

Closed
willdurand opened this issue Jan 7, 2019 · 8 comments · Fixed by mozilla/addons-frontend#7313
Closed
Assignees
Milestone

Comments

@willdurand
Copy link
Member

postcss outputs two warning in the build logs:

[0] WARNING in ./src/amo/components/AddonSummaryCard/styles.scss (./node_modules/css-loader/dist/cjs.js??ref--5-1!./node_modules/postcss-loader/src??ref--5-2!./node_modules/sass-loader/lib/loader.js??ref--5-3!./src/amo/components/AddonSummaryCard/styles.scss)
[0] Module Warning (from ./node_modules/postcss-loader/src/index.js):
[0] Warning
[0]
[0] (35:3) start value has mixed support, consider using flex-start instead
[0]  @ ./src/amo/components/AddonSummaryCard/styles.scss 2:14-222 21:1-42:3 22:19-227
[0]  @ ./src/amo/components/AddonSummaryCard/index.js
[0]  @ ./src/amo/pages/AddonInfo/index.js
[0]  @ ./src/amo/components/Routes/index.js
[0]  @ ./src/amo/components/App/index.js
[0]  @ ./src/amo/client.js
[0]  @ multi webpack-hot-middleware/client?path=//127.0.0.1:3001/__webpack_hmr amo/client
[0]
[0] WARNING in ./src/amo/components/RatingsByStar/styles.scss (./node_modules/css-loader/dist/cjs.js??ref--5-1!./node_modules/postcss-loader/src??ref--5-2!./node_modules/sass-loader/lib/loader.js??ref--5-3!./src/amo/components/RatingsByStar/styles.scss)
[0] Module Warning (from ./node_modules/postcss-loader/src/index.js):
[0] Warning
[0]
[0] (63:3) end value has mixed support, consider using flex-end instead
[0]  @ ./src/amo/components/RatingsByStar/styles.scss 2:14-222 21:1-42:3 22:19-227
[0]  @ ./src/amo/components/RatingsByStar/index.js
[0]  @ ./src/amo/components/AddonMeta/index.js
[0]  @ ./src/amo/pages/Addon/index.js
[0]  @ ./src/amo/components/Routes/index.js
[0]  @ ./src/amo/components/App/index.js
[0]  @ ./src/amo/client.js
[0]  @ multi webpack-hot-middleware/client?path=//127.0.0.1:3001/__webpack_hmr amo/client

We should use flex-start instead of start. Same for flex-end.

@AlexandraMoga
Copy link

@willdurand does this require QA?
Thanks

@willdurand
Copy link
Member Author

@willdurand does this require QA?

mmh, nope. Thanks for the reminder, I've added the "qa: not needed" label.

@mks21998
Copy link

mks21998 commented Nov 21, 2019

@willdurand I too got stuck at the same problem with the same error statement. If you got any solution then please share it here.
Thanks!

@ambujkhanna
Copy link

@mks21998 : I also faced similar issue. Here was my solution.
**Earlier: ** -webkit-box-pack: start; -ms-flex-pack: start; justify-content: flex-start; -webkit-box-align: start; -ms-flex-align: start; **align-items: start;**

Solution : -webkit-box-pack: start; -ms-flex-pack: start; justify-content: flex-start; -webkit-box-align: start; -ms-flex-align: start; **align-items: flex-start;**

This one solved my warning issue.

@Tecayehuatl
Copy link

I my case i was using justify-content: start; property instead justify-content: flex-start; using flex-start value solved it!

@VirajThale
Copy link

I my case i was using justify-content: start; property instead justify-content: flex-start; using flex-start value solved it!

thanks it solve it

@henry25225
Copy link

I'm importing https://www.npmjs.com/package/@grapecity/activereports for creating report design. It shows the following warning.
./node_modules/@grapecity/activereports/styles/ar-js-designer.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./node_modules/@grapecity/activereports/styles/ar-js-designer.css)
How can I resolve this issue from 3rd party library?

@abramyangCN
Copy link

I'm importing https://www.npmjs.com/package/@grapecity/activereports for creating report design. It shows the following warning.
./node_modules/@grapecity/activereports/styles/ar-js-designer.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./node_modules/@grapecity/activereports/styles/ar-js-designer.css)
How can I resolve this issue from 3rd party library?

the same issue here
is there any option to ignore or exclude third party or node_modules?
otherwise we just contact grapecity and let them fix the issue
once you fix it please let me know

@mozilla mozilla locked as off-topic and limited conversation to collaborators Jul 27, 2021
@mozilla mozilla unlocked this conversation May 4, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 4, 2024
@mozilla mozilla locked as off-topic and limited conversation to collaborators May 4, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants