Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy QRCode images when building blog-utils lib #10956

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

willdurand
Copy link
Member

Fixes mozilla/addons#14311


With this patch, we don't have the QR code images anymore:

$ ls -l dist/
total 3392
-rw-r--r--  1 williamdurand  staff   112B Oct  8 08:47 README.md
-rw-r--r--  1 williamdurand  staff   925K Oct  8 08:48 node.js
-rw-r--r--  1 williamdurand  staff   416B Oct  8 08:47 package.json
-rw-r--r--  1 williamdurand  staff   147K Oct  8 08:48 style.css
-rw-r--r--  1 williamdurand  staff   612K Oct  8 08:48 web.js

@willdurand willdurand requested review from a team and eviljeff and removed request for a team October 8, 2021 06:50
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #10956 (5679452) into master (896a3b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   mozilla/addons-frontend#10956   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         258      258           
  Lines        7540     7540           
  Branches     1367     1367           
=======================================
  Hits         7419     7419           
  Misses        113      113           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896a3b1...5679452. Read the comment docs.

@willdurand willdurand merged commit 22b231f into master Oct 8, 2021
@willdurand willdurand deleted the fix-webpack-blog-utils branch October 8, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not embed QR code images in addons-frontend-blog-utils
2 participants