Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the validator need to be localized? #40

Closed
muffinresearch opened this issue Oct 1, 2015 · 5 comments
Closed

Does the validator need to be localized? #40

muffinresearch opened this issue Oct 1, 2015 · 5 comments
Assignees

Comments

@muffinresearch
Copy link
Contributor

I see the current validator isn't - but I wondered if that might make sense.

@tofumatt
Copy link
Contributor

tofumatt commented Oct 1, 2015

Need is probably a strong word, but no reason not to build it with that it mind. I don't mind going through all the strings and wrapping them in gettext or whatnot.

  • tofumatt (Sent from mobile)

On 1 Oct 2015, 21:27 +0100, Stuart Colvillenotifications@github.com, wrote:

I see the current tool isn't - but I wondered if that might make sense.


Reply to this email directly orview it on GitHub(#40).

@muffinresearch
Copy link
Contributor Author

I've not seen / heard a requirement for this but in terms of improving the add-on ecosystem it seems like it would be nice if the tool was localized both when used from the web and as a cli tool.

@tofumatt
Copy link
Contributor

tofumatt commented Oct 2, 2015

It should be minimal effort to do, so let's add it to the next sprint. I'll take it on then.

@tofumatt tofumatt self-assigned this Oct 2, 2015
@tofumatt
Copy link
Contributor

tofumatt commented Oct 2, 2015

NOTE: Explore es6 gettext/translating template string.

@muffinresearch
Copy link
Contributor Author

Going to raise a new issue for the last point re: tags and templating for l10n in es6. Otherwise we have consensus that we'll at a minimum wrap strings in gettext as we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants