Do not warn about nesting css selectors when firefoxStrictMinVersion is >= 117 #5164
Conversation
schmop
force-pushed
the
css-nesting-selectors-min-version
branch
from
a621607 to
cec0430
Compare
…is >= 117 Co-authored-by: JimKnoxx <imknoxx@knoxx.media>
schmop
force-pushed
the
css-nesting-selectors-min-version
branch
from
cec0430 to
23420b2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5164 +/- ##
=======================================
Coverage 98.73% 98.74%
=======================================
Files 54 54
Lines 2932 2937 +5
Branches 893 896 +3
=======================================
+ Hits 2895 2900 +5
Misses 37 37 ☔ View full report in Codecov by Sentry. |
src/parsers/manifestjson.js
Outdated
| * @property {string} version | ||
| * @property {string} firefoxMinVersion | ||
| * @property {Set<string>} experimentApiPaths | ||
| */ |
There was a problem hiding this comment.
Can that be either omitted or moved near getMetadata()?
There was a problem hiding this comment.
I moved it down. I added JSDoc, because it helped me a great deal understand what structure I can rely on. I thought it might help future devs aswell, that do not know the internals yet.
There was a problem hiding this comment.
I am not against but I think I'd rather see that added in a different PR.
| * @param {string|Buffer|import('stream').Readable} contents | ||
| * @param {string} filename | ||
| * @param {ScannerOptions} options | ||
| */ |
There was a problem hiding this comment.
That kinda looks like typescript stuff, is this really needed as part of this PR?
There was a problem hiding this comment.
These kind of JSDoc comments are the compromise of having types without using typescript. It helps documenting interfaces, allowing IDEs with code suggestions and helping new devs to faster move around foreign code. I typed parts where I struggled with the given interfaces and needed to dig deeper and documented it right away, so others don't have to. Is this kind of type-documenting style unwelcome in this repository? I can definitely just remove it.
Co-authored-by: William Durand <will+git@drnd.me>
Fixes #5102
Since Firefox Version 117 CSS selector nesting is supported.
This is not reflected in the
rules/css/invalidNestingSelectors.jsof the addons-linter.In this changeset I introduced a check against the
firefoxMinStrictVersion, orstrict_min_versionwhich is specified in themanifest.json.Fixes #ISSUENUMat the top of your PR.┆Issue is synchronized with this Jira Task