Prevent errors when non-string CSP values are defined in the manifest #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5195 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 54 54
Lines 2937 2940 +3
Branches 896 898 +2
=======================================
+ Hits 2900 2903 +3
Misses 37 37 ☔ View full report in Codecov by Sentry. |
rpl
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
@willdurand the fix looks reasonable as is, the inline comments are related to a small addition to the test case and considering not validating the csp strings at all if the value of the content_security_policy field is an array (mainly to avoid to validate values that would be in an invalid form anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5194
┆Issue is synchronized with this Jira Task