Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the use of the enterprise flag #5331

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Prevent the use of the enterprise flag #5331

merged 1 commit into from
Jun 13, 2024

Conversation

willdurand
Copy link
Member

Fixes #5330

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (961f431) to head (b95afb9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5331   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          51       51           
  Lines        2892     2896    +4     
  Branches      886      887    +1     
=======================================
+ Hits         2856     2860    +4     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand requested a review from rpl June 6, 2024 14:12
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand this PR looks pretty good and straightforward, I only collected one nit (related to some small proposed tweaks to the rule description, not really mandatory and we can always change the message later if we think it would be better to reword it) and a couple of thoughts on the test side (but mostly nice to have to ensure that if we change the implementation we can't mistakenly not report the error under certain corner cases).

Given that nothing collected in this review pass is that critical or blocking, I'm also approving this right away.

src/messages/manifestjson.js Show resolved Hide resolved
tests/unit/parsers/test.manifestjson.js Outdated Show resolved Hide resolved
tests/unit/parsers/test.manifestjson.js Outdated Show resolved Hide resolved
@willdurand willdurand merged commit 7cb36f3 into master Jun 13, 2024
5 checks passed
@willdurand willdurand deleted the enterprise branch June 13, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent the use of the enterprise flag
2 participants