Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim relaxed-json dependencies #5420

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Aug 25, 2024

As mentioned in #3910 (comment), relaxed-json has duplicate key detection so it cannot easily be replaced.

And we don't have to. The only problem with the package is that it has a lot of CLI dependencies.

Since the package has been stable/undeveloped for 5 years, I just forked it to publish an API-only version, documenting it: https://github.com/fregante/relaxed-json#readme. This was brought up to its developer 3 years ago already but no response.

This drops all of its deps:

Screenshot 1

@willdurand
Copy link
Member

@fregante can you rebase please?

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (924db3f) to head (2f3881e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5420   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          51       51           
  Lines        2855     2855           
  Branches      867      867           
=======================================
  Hits         2820     2820           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand merged commit cc07336 into mozilla:master Sep 19, 2024
5 checks passed
@fregante fregante deleted the trim-relaxed-json branch September 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace relaxed-json with strip-json-comments
2 participants