Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove localization in this project #5520

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove localization in this project #5520

merged 1 commit into from
Dec 12, 2024

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Dec 4, 2024 •
edited
Loading

Fixes #5521

@willdurand willdurand force-pushed the rm-l10n branch 3 times, most recently from 57e353e to 7131d7f Compare December 4, 2024 12:03
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (2bf19a8) to head (633e79b).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5520      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files          51       51              
  Lines        2855     2844      -11     
  Branches      867      867              
==========================================
- Hits         2820     2809      -11     
  Misses         35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand marked this pull request as ready for review December 4, 2024 12:08
@willdurand willdurand requested a review from rpl December 4, 2024 12:08
rpl
rpl approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only an optional nit (mentioning in case we feel it may be worth including that in this PR instead of filing it as a followup, but I'm fine either way).

tests/unit/test.utils.js Outdated Show resolved Hide resolved
@willdurand willdurand merged commit b40366c into master Dec 12, 2024
3 checks passed
@willdurand willdurand deleted the rm-l10n branch December 12, 2024 08:26
This was referenced Feb 13, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove localization in this project
2 participants
@willdurand @rpl