Move function deps to peer dependencies #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
erf, we don't have CI right now because travis-ci.com does not work for mozilla repos anymore |
rpl
approved these changes
Dec 2, 2020
Comment on lines
+20
to
+26
| "peerDependencies": { | ||
| "@types/download": "6.2.4", | ||
| "body-parser": "1.19.0", | ||
| "download": "8.0.0", | ||
| "express": "4.17.1", | ||
| "safe-compare": "1.1.4" | ||
| }, |
There was a problem hiding this comment.
it is a bit unfortunate that the peerDependencies are all being duplicated in the devDependencies, which I guess is for testing purpose. Based on a quick look it seems that this is the common practice in these cases and so that's annoying but fine (especially given that renovatebot should be already helping us to be sure to update both at the same time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
This patch moves the function-related deps to the
peerDependenciessection. Because we're using Yarn in most cases, we have to copy those dependencies to thedevDependenciessection as well so that we can run the test suite, work on the lib, etc. locally. This won't affect the packages we release, though.