Apply suggestions from code review

Co-authored-by: William Durand <will+git@drnd.me>

src/olympia/blocklist/tests/test_cron.py

@@ -220,8 +220,8 @@ def test_upload_stash_unless_force_base(self):
         ].call_args_list == [
             mock.call(
                 self.current_time,
-                filter_list=[BlockType.BLOCKED.name] if force_base else [],
-                create_stash=not force_base,
+                filter_list=[],
+                create_stash=True,
             )
         ]
         mlbf = MLBF.load_from_storage(self.current_time)

src/olympia/blocklist/tests/test_tasks.py

@@ -298,8 +298,8 @@ def test_skip_cleanup_when_no_filters(self):
 
     def test_cleanup_old_records(self):
         """
-        Clean up 0 because its the only record matching the uplaoded filters
-        attachment_type or is older than genreation_time
+        Clean up 0 because it's the only record matching the uploaded filters
+        attachment_type or is older than generation_time.
         """
         self._test_cleanup_old_records(
             filter_list={
@@ -317,7 +317,7 @@ def test_cleanup_old_records(self):
 
     def test_cleanup_oldest_stash_records(self):
         """
-        The oldest base id time is (self.generation_time -3)
+        The oldest base id time is (self.generation_time - 3)
         Delete 0 as matching attachment
         Delete 1 as older than base id
         """