Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency less to v4 #16205

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update dependency less to v4 #16205

merged 1 commit into from
Jan 4, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 18, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
less (source) 3.13.0 -> 4.0.0 age adoption passing confidence

Release Notes

less/less.js

v4.0.0

Compare Source

v3.13.1

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@eviljeff eviljeff merged commit cadd311 into master Jan 4, 2021
@eviljeff eviljeff deleted the renovate/less-4.x branch January 4, 2021 10:45
@diox
Copy link
Member

diox commented Jan 4, 2021

This seems to be the cause of this error:
ParseError: Unrecognized input. Possibly missing '(' in mixin call. in /code/static/css/impala/typography.less on line 121, column 9:

Not sure if this has real implications yet.

@eviljeff
Copy link
Member

eviljeff commented Jan 4, 2021

🙄 I guess this is a silent error (can we make it fail in CI at least?).

@eviljeff
Copy link
Member

eviljeff commented Jan 4, 2021

looks like less/less.js@67ce103 "Require parens after mixin call"

@eviljeff
Copy link
Member

eviljeff commented Jan 4, 2021

it'd be nice if the changelog for a breaking major release wasn't just a link to a PR that's a bunch of random commits without explanation (or even any issues linked) to explain the reasoning behind the changes.

@diox
Copy link
Member

diox commented Jan 4, 2021

🙄 I guess this is a silent error (can we make it fail in CI at least?).

I'm guessing this is silent because compress_assets is just ignoring it - when it calls less, it should check the return value and abort/raise when the return value of the command is not right - hopefully there is a different return value in that case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants